Date: Fri, 9 Sep 2016 04:16:53 +0000 (UTC) From: Justin Hibbits <jhibbits@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r305636 - head/sys/ddb Message-ID: <201609090416.u894GriK087316@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhibbits Date: Fri Sep 9 04:16:53 2016 New Revision: 305636 URL: https://svnweb.freebsd.org/changeset/base/305636 Log: Correct the type of db_cmd_loop_done. On big endian hardware that uses 1 byte bool a type mismatch of bool vs int will cause the least signifcant byte of db_cmd_loop_done to be set, but the MSB to be read, and read as 0. This causes ddb to stay in an infinite loop. MFC after: 1 week Modified: head/sys/ddb/db_command.c Modified: head/sys/ddb/db_command.c ============================================================================== --- head/sys/ddb/db_command.c Fri Sep 9 02:02:13 2016 (r305635) +++ head/sys/ddb/db_command.c Fri Sep 9 04:16:53 2016 (r305636) @@ -59,7 +59,7 @@ __FBSDID("$FreeBSD$"); /* * Exported global variables */ -bool db_cmd_loop_done; +int db_cmd_loop_done; db_addr_t db_dot; db_addr_t db_last_addr; db_addr_t db_prev;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201609090416.u894GriK087316>