Date: Fri, 13 Oct 2017 09:49:06 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r324580 - head/sys/net80211 Message-ID: <be6c0415-1510-145f-5b46-d53609ff5b41@selasky.org> In-Reply-To: <CAJ-Vmo=7AVqRjnGmsTX5PJZ-0mSiSie1-gcw9LsAmYRTyS-DaQ@mail.gmail.com> References: <201710130649.v9D6n7cI036282@repo.freebsd.org> <b4ade0cf-8658-508d-f806-7db54d605b57@selasky.org> <CAJ-Vmo=7AVqRjnGmsTX5PJZ-0mSiSie1-gcw9LsAmYRTyS-DaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/13/17 09:45, Adrian Chadd wrote:
> no, it checks it.
>
>
> -a
>
>
> On 13 October 2017 at 00:11, Hans Petter Selasky <hps@selasky.org> wrote:
>> On 10/13/17 08:49, Adrian Chadd wrote:
>>>
>>> if (ieee80211_check_rxseq_amsdu_more(rxs)) {
>>
>> ^^^ does this line also need a NULL check?
>>
>>
>>> ni->ni_rxseqs[tid] = rxseq;
>>> - if (ieee80211_check_rxseq_amsdu(rxs))
>>> + if ((rxs != NULL) && ieee80211_check_rxseq_amsdu(rxs))
>>> IEEE80211_NODE_STAT(ni, rx_amsdu_more_end);
>>
>>
>> --HPS
>
>
Then why are you checking that pointer twice? Why not make
ieee80211_check_rxseq_amsdu_more() return false, if rxs is NULL?
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?be6c0415-1510-145f-5b46-d53609ff5b41>