Date: Tue, 28 Nov 2023 15:31:45 +0100 From: tuexen@fh-muenster.de To: Ronald Klop <ronald-lists@klop.ws> Cc: Randall Stewart <rrs@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 6a79e48076bc - main - Fix two latent bugs in hpts. One where a static is put on a local variable, the other an initialization bug where we should be setting tv.tv_sec to 0. Message-ID: <4A4E5230-E309-4CB0-9EE5-20DAD61BF255@fh-muenster.de> In-Reply-To: <737498435.7036.1701179052815@localhost> References: <202311271939.3ARJdQJK020166@gitrepo.freebsd.org> <737498435.7036.1701179052815@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Nov 28, 2023, at 14:44, Ronald Klop <ronald-lists@klop.ws> wrote: > > > The PR you mention gives me the friendly message of > > " > You must enter a valid bug number! > " > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275482 > > Typo somewhere? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275382 > > A quick search gives me https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275382 which looks a lot like what you describe in the commit. Yes that is it. Best regards Michael > > Regards, > Ronald. > > Van: Randall Stewart <rrs@FreeBSD.org> > Datum: maandag, 27 november 2023 20:39 > Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org > Onderwerp: git: 6a79e48076bc - main - Fix two latent bugs in hpts. One where a static is put on a local variable, the other an initialization bug where we should be setting tv.tv_sec to 0. > The branch main has been updated by rrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6a79e48076bcce3e902323e62689eacb98faa180 > > commit 6a79e48076bcce3e902323e62689eacb98faa180 > Author: Randall Stewart <rrs@FreeBSD.org> > AuthorDate: 2023-11-27 19:38:06 +0000 > Commit: Randall Stewart <rrs@FreeBSD.org> > CommitDate: 2023-11-27 19:38:06 +0000 > > Fix two latent bugs in hpts. One where a static is put on > a local variable, the other an initialization bug where > we should be setting tv.tv_sec to 0. > > PR: 275482 > --- > sys/netinet/tcp_hpts.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/netinet/tcp_hpts.c b/sys/netinet/tcp_hpts.c > index 92b2f69c9e58..d673ccbe4a73 100644 > --- a/sys/netinet/tcp_hpts.c > +++ b/sys/netinet/tcp_hpts.c > @@ -1519,6 +1519,7 @@ __tcp_run_hpts(struct tcp_hpts_entry *hpts) > hpts->p_mysleep.tv_usec = dynamic_min_sleep; > /* Reschedule with new to value */ > tcp_hpts_set_max_sleep(hpts, 0); > + tv.tv_sec = 0; > tv.tv_usec = hpts->p_hpts_sleep_time * HPTS_TICKS_PER_SLOT; > /* Validate its in the right ranges */ > if (tv.tv_usec < hpts->p_mysleep.tv_usec) { > @@ -1600,7 +1601,7 @@ tcp_choose_hpts_to_run(void) > void > tcp_run_hpts(void) > { > - static struct tcp_hpts_entry *hpts; > + struct tcp_hpts_entry *hpts; > struct epoch_tracker et; > > NET_EPOCH_ENTER(et); > > [-- Attachment #2 --] 0 *H 010 `He 0 *H 00 %ف0 *H 01 0 UDE1+0)U "T-Systems Enterprise Services GmbH1 0 U T-Systems Trust Center1%0#U T-TeleSec GlobalRoot Class 20 160222133822Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20"0 *H 0 `fAsMg9Z`GNWKVlUvFEc>pԫT#7( ]Ę7 fxJ2)y T_Jx4twMYZ/l< 5e 2mZjKb84YE6Ixjm[k<q;gz6N)=Q\ 4 u9 i%=+ ;U*^3 1Fk Y t0p0U 0 U 2&JJK 0 U #0Y 6 y"kaҸ,˂J0U 003U ,0*0 +!,0 +!, 0g 0LU E0C0A?=;http://pki0336.telesec.de/rl/TeleSec_GlobalRoot_Class_2.crl0+z0x0,+0 http://ocsp0336.telesec.de/ocspr0H+0<http://pki0336.telesec.de/crt/TeleSec_GlobalRoot_Class_2.cer0 *H >eV-;qOں)!F.8y8tv]bL3j2,LG`Utk,ykMP f0"rM>[ϙR9. D~i;u ;"lGG4}=wMOY>GJXoB .M<I&6,"͋xU;D RiТSW{$Jer900c ,=0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1-0+U$DFN-Verein Certification Authority 20 160524113840Z 310222235959Z01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0"0 *H 0 ;y G i9٢0r )_KhLk {-n:W Q6pmc.@уLf= di囤rh9QyӮ/]cqK9zBi@p翞 MGH_e*I- ? T/:W~xJA}S_ȳ*0$? MR6$eǖs$hYv~ x<K7S:8Gmd=<ZEJʀ|LL 00U 00U 0)U "0 0 +!, 0 +!,0 U k:S୲2 ;t0 U #02&JJK 0U 00@><:http://cdp1.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0@><:http://cdp2.pca.dfn.de/global-root-g2-ca/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0J+0>http://cdp1.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0J+0>http://cdp2.pca.dfn.de/global-root-g2-ca/pub/cacert/cacert.crt0 *H xENU j>xh5 ?k8w,>̨͠3$b6LxnPn`OR1CFubnfQB1gPI9 ˟ʆHK+f8 W-L_>\)9l{F 8ܰ?q 3Hc%%<z{Wn8︠/[Kl=w 3Sv&%Ao/|~ `]AaI)ب-uJU4"0)0 &BґA7?0 *H 01 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA0 220530132215Z 250529132215Z01 0 UDE1 0U Nordrhein-Westfalen10U Muenster10U FH Muenster1200U )Fachbereich Elektrotechnik und Informatik10 U Tuexen10U* Michael10U Michael Tuexen0"0 *H 0 {R}HI'ϻYĩhx+C 4P"Ty)PRw Vf>1{Bak eĜ~< 6?cym,m d 3 nDzX l}$v#dij1J b鴽/ ;& "n 6 er8vʝ gKVq}c1ｖ<;i8BU ~X,s|tٯߨ{1H\EfvzZ ؆M/t$1"Q$Usמ>ׅ*fߗqVzwz2졈l7]) &f'c >ڒ'veV)뛿=a/zd! $6m~v<;B?<=(ӂzT 9.#{_aJEP= ɽxO5mtZ q9KHAE1Iٵud[ W K!*-w N N0J0>U 7050 +!,0+!, 0+!, 0 U 0 0U 0 U %0++0 U PD:~WEǴ(q0 U #0k:S୲2 ;t0 U 0tuexen@fh-muenster.de0U 00?=;9http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0?=;9http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/crl/cacrl.crl0+003+0'http://ocsp.pca.dfn.de/OCSP-Server/OCSP0I+0=http://cdp1.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0I+0=http://cdp2.pca.dfn.de/dfn-ca-global-g2/pub/cacert/cacert.crt0 *H ./x ĬNuӌ.- |2 Rz PtR4`]`OɡX, լUDZP}4?U+ς ` v<[ 7*;j .!8Y{ߣGIV8[xᲒ)*MZX1銘~4kr90@Yۜmy~?Q];2+ܩ̹b0IU0YW{; aU k10001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 `He 0 *H 1 *H 0 *H 1 231128143145Z0/ *H 1" V R綁E +$t cLO0 +71001 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H 101 0 UDE1E0CU <Verein zur Foerderung eines Deutschen Forschungsnetzes e. V.10U DFN-PKI1%0#U DFN-Verein Global Issuing CA &BґA7?0 *H v ɴԚLu)C75Bq 1:DLuၱ6| OH/ŀ.tu!9d=FՇ v9]^A]ޅ4ʞ8WooqzGJI' ;dǵpID8-rp"RO=w諚~JLJnXjYle6L TH&xԜ >7Ῐ;*Mx; 1+pH|L U nE{>2~W1jT~]@W~fpUy{-?HD@LG+(r}بşyY*T㸧2]rD0<ef/! wlX^@.s4ތ.v)`'w Zp\QMdH2{]H.p'd5| oY2 #`g)A W=9o vɋQG>;C')4]ѹrP68mR- Ike 7NK&Uf/zK
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A4E5230-E309-4CB0-9EE5-20DAD61BF255>