Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Mar 2004 12:06:01 -0800 (PST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 47931 for review
Message-ID:  <200403012006.i21K61NN052897@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=47931

Change 47931 by rwatson@rwatson_tislabs on 2004/03/01 12:05:04

	Explicitly document semantic difference between DROP/
	PICKUP_GIANT() and NET_DROP_GIANT() and NET_PICKUP_GIANT().

Affected files ...

.. //depot/projects/netperf_socket/sys/sys/mutex.h#2 edit

Differences ...

==== //depot/projects/netperf_socket/sys/sys/mutex.h#2 (text+ko) ====

@@ -348,7 +348,10 @@
  * the Giant lock.
  *
  * This mechanism is intended as temporary until everything of
- * importance is properly locked.
+ * importance is properly locked.  Note: the semantics for
+ * NET_{PICKUP,DROP}_GIANT() are not the same as DROP_GIANT()
+ * and PICKUP_GIANT(), as they are plain mutex operations
+ * without a recursion counter.
  */
 extern	int debug_mpsafenet;		/* defined in net/netisr.c */
 #define	NET_PICKUP_GIANT() do {						\



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403012006.i21K61NN052897>