Date: Sat, 6 Apr 2019 01:47:15 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Ed Maste <emaste@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <20190406014249.N4174@besplex.bde.org> In-Reply-To: <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w@mail.gmail.com> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 5 Apr 2019, Ed Maste wrote:
> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
>>
>
>>> +static const u_char dot_name[] = {
>>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
>>> +static const u_char dotdot_name[] = {
>>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
>>> +
>>
>> Does it make since to encode these as hex or octal constants,
>> one can not tell that those are different values in an easy
>> manner. They all look like '.' in the diff, and probably
>> in most editors.
No, but it makes sense to write them as string constants. They are just
the strings "." and ".." padded with spaces to length 11, except they
are not actually strings since they are not NUL terminated. 11 is for
8+3 msdos short file names. These are not NUL terminated either, but
it should be easy to ignore the extra NUL given by the string constants.
> They are all either '.' or ' ', the commas are just list separators.
> IMO spaces after the commas would make it slightly easier to see.
The single quotes looking like commas indeed makes this hard to read.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190406014249.N4174>