Date: Wed, 29 Jul 2015 15:36:09 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r286007 - in stable/10/contrib/llvm: include/llvm/CodeGen lib/CodeGen/SelectionDAG lib/Target/X86 Message-ID: <5EDE437E-8D2E-4ADC-A90A-730CD9726AEC@FreeBSD.org> In-Reply-To: <CABh_MKkYM03vVivwYeHxpa1_nEqCcri57VXhVhXRoHOWS5XykA@mail.gmail.com> References: <201507291259.t6TCxHX4035145@repo.freebsd.org> <CABh_MKkYM03vVivwYeHxpa1_nEqCcri57VXhVhXRoHOWS5XykA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_3CF51DFE-9729-4780-847A-C3194CC486B4
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On 29 Jul 2015, at 15:21, Ed Schouten <ed@nuxi.nl> wrote:
> 2015-07-29 14:59 GMT+02:00 Dimitry Andric <dim@freebsd.org>:
>> + std::unique_ptr<MatchStateUpdater> MSU;
>
> Is it safe to use std::unique_ptr<> in FreeBSD 10 sources? As in,
> would it still allow upgrading to 10.2 from 9.x and 10.{0,1}?
Hmm, that's a good one. I keep forgetting that this needs to be
buildable with obsolete compilers. :-(
I'll have a look if this can be fixed using pre-C++11 constructs, or
otherwise revert the fix. This could make it more difficult to upgrade
later, though I did not see the crash reported by Jonathan myself.
-Dimitry
--Apple-Mail=_3CF51DFE-9729-4780-847A-C3194CC486B4
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.27
iEYEARECAAYFAlW41s8ACgkQsF6jCi4glqNjrwCfQCzhCezZtPDi4L2duVUF0qU0
tQIAn1i5hNu6C/u//oChe7G6h8n9EHje
=GsEi
-----END PGP SIGNATURE-----
--Apple-Mail=_3CF51DFE-9729-4780-847A-C3194CC486B4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5EDE437E-8D2E-4ADC-A90A-730CD9726AEC>