Date: Thu, 8 Jan 2004 10:05:14 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.obj.mk Message-ID: <20040108080514.GB27761@FreeBSD.org.ua> In-Reply-To: <200401072041.i07Kf4Th004736@green.bikeshed.org> References: <20040107202112.GD21522@FreeBSD.org.ua> <200401072041.i07Kf4Th004736@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Jan 07, 2004 at 03:41:03PM -0500, Brian F. Feldman wrote:
> Ruslan Ermilov <ru@FreeBSD.org> wrote:
> > On Thu, Jan 01, 2004 at 09:05:48PM -0800, Brian Feldman wrote:
> > > green 2004/01/01 21:05:48 PST
> > >=20
> > > FreeBSD src repository
> > >=20
> > > Modified files:
> > > share/mk bsd.obj.mk=20
> > > Log:
> > > Fix a very corner case when you want to make cleandir SUBDIRs which
> > > are built using a ${MAKE} that's not just "make".
> > > =20
> > > Test by: make universe (followed by cleandirs)
> > > =20
> > > Revision Changes Path
> > > 1.49 +2 -2 src/share/mk/bsd.obj.mk
> > >=20
> > The old version used ${MAKE}, why this was a problem at all?
>=20
> The ${MAKE} that it uses would be overridden by the default ${MAKE} value=
=20
> each time; this doesn't occur when dependencies are executed, though.
>=20
Please explain in more detail. With the below makefile,
: all:
: @cd ${.CURDIR}; ${MAKE} print-make
:=20
: print-make:
: @echo ${MAKE}
running /usr/bin/make will rightfully print "/usr/bin/make".
make(1)'s main() always sets MAKE to argv[0] as its first task.
Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org
--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQE//Q85Ukv4P6juNwoRAuxXAJ4r7RhqSad+L+ekbP72lG6h6GHnuwCgh2u5
St0WMf8vxntfkw7ED/ktQKw=
=vmZ3
-----END PGP SIGNATURE-----
--X1bOJ3K7DJ5YkBrT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040108080514.GB27761>