Date: Fri, 5 Apr 2019 07:51:02 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Bruce Evans <brde@optusnet.com.au> Cc: Ed Maste <emaste@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <201904051451.x35Ep2ov039561@gndrsh.dnsmgr.net> In-Reply-To: <20190406014249.N4174@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, 5 Apr 2019, Ed Maste wrote:
>
> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> >>
> >
> >>> +static const u_char dot_name[] = {
> >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>> +static const u_char dotdot_name[] = {
> >>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>> +
> >>
> >> Does it make since to encode these as hex or octal constants,
> >> one can not tell that those are different values in an easy
> >> manner. They all look like '.' in the diff, and probably
> >> in most editors.
>
> No, but it makes sense to write them as string constants. They are just
> the strings "." and ".." padded with spaces to length 11, except they
> are not actually strings since they are not NUL terminated. 11 is for
> 8+3 msdos short file names. These are not NUL terminated either, but
> it should be easy to ignore the extra NUL given by the string constants.
There is a review up, and that is exactly what has been done,
dot_names[11] = ". "
> > They are all either '.' or ' ', the commas are just list separators.
> > IMO spaces after the commas would make it slightly easier to see.
>
> The single quotes looking like commas indeed makes this hard to read.
Almost headache creating :-).
> Bruce
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904051451.x35Ep2ov039561>