Date: Fri, 24 Oct 2014 12:14:48 -0400 From: John Baldwin <jhb@freebsd.org> To: Marcelo Araujo <araujo@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r273576 - head/sys/dev/uart Message-ID: <235737869.CpTJALnJpW@ralph.baldwin.cx> In-Reply-To: <201410240539.s9O5dWWK002150@svn.freebsd.org> References: <201410240539.s9O5dWWK002150@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, October 24, 2014 05:39:32 AM Marcelo Araujo wrote: > Author: araujo (ports committer) > Date: Fri Oct 24 05:39:32 2014 > New Revision: 273576 > URL: https://svnweb.freebsd.org/changeset/base/273576 > > Log: > Fix a leaked Storage Variable. > > Phabric: D981 > Submitted by: myself > Reported by: Coverity > CID: 1248848 > Reworked by: kevlo > Reviewed by: marcel, davide, ray, kevlo > Approved by: marcel, kevlo > > Modified: > head/sys/dev/uart/uart_subr.c > > Modified: head/sys/dev/uart/uart_subr.c > ============================================================================== > --- head/sys/dev/uart/uart_subr.c Fri Oct 24 04:01:14 2014 (r273575) > +++ head/sys/dev/uart/uart_subr.c Fri Oct 24 05:39:32 2014 (r273576) > @@ -196,7 +196,7 @@ out: > int > uart_getenv(int devtype, struct uart_devinfo *di, struct uart_class *class) > { > - const char *spec; > + const char *cp, *spec; Dropping const here is preferable to using __DECONST() for the freeenv() calls. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?235737869.CpTJALnJpW>