Date: Thu, 3 Apr 2003 11:53:50 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c Message-ID: <20030403085350.GA37174@sunbay.com> In-Reply-To: <20030403180026.A29934@gamplex.bde.org> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Apr 03, 2003 at 06:04:25PM +1000, Bruce Evans wrote:
> On Wed, 2 Apr 2003, Marcel Moolenaar wrote:
>
> > Please, everybody, do not set WARNS=5 on anything because it breaks
> > non-optimized builds:
> >
> > cc -g -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/.. -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> > -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized -c decode.c
> > cc1: warnings being treated as errors
> > cc1: warning: -Wuninitialized is not supported without -O
> > *** Error code 1
>
> Too late:
>
[...]
> This is mostly a bug in the implementation of WARNS.
>
How's this bugfix?
%%%
Index: bsd.sys.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
retrieving revision 1.12
diff -u -r1.12 bsd.sys.mk
--- bsd.sys.mk 31 Mar 2003 13:10:51 -0000 1.12
+++ bsd.sys.mk 3 Apr 2003 08:48:40 -0000
@@ -25,7 +25,7 @@
. if ${WARNS} > 3
CFLAGS += -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
. endif
-. if ${WARNS} > 4
+. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
CFLAGS += -Wuninitialized
. endif
# BDECFLAGS
%%%
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+i/aeUkv4P6juNwoRAvMfAJ92BfE7tdmhSGhqOLvIFqIkkxMdTgCfdZ/b
lJLGBqenQwsC3JViOISySQU=
=z7fa
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030403085350.GA37174>