Date: Mon, 28 Feb 2011 20:37:48 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/sis if_sis.c if_sisreg.h Message-ID: <201102282037.p1SKbwaH076095@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2011-02-28 20:37:48 UTC
FreeBSD src repository
Modified files:
sys/dev/sis if_sis.c if_sisreg.h
Log:
SVN rev 219102 on 2011-02-28 20:37:48Z by yongari
Make sure changing ownership of RX descriptor to be done as last
operation. Previously ownership was transferred to hardware before
setting address of new RX buffer such that it was possible for
hardware to use wrong RX buffer address.
While here keep compiler from re-ordering instructions by declaring
descriptor members volatile. Memory barriers would do the same job
but volatile is supposed to be cheaper than using memory barriers,
especially on MP systems.
Submitted by: marius
MFC after: 1 week
Revision Changes Path
1.31 +1 -1 src/sys/dev/sis/if_sis.c
1.11 +2 -2 src/sys/dev/sis/if_sisreg.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102282037.p1SKbwaH076095>