Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jul 2026 19:23:25 -0700
From:      "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To:        Enji Cooper <ngie@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 4db3872aabc3 - main - Only build secure/libexec/ssh-sk-helper if MK_USB == no
Message-ID:  <7C07696C-0E56-44A5-8AE4-9270891CC973@gmail.com>
In-Reply-To: <6a611b21.1f0c2.2c3b5692@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]

> On Jul 22, 2026, at 12:33 PM, Enji Cooper <ngie@FreeBSD.org> wrote:
> 
> The branch main has been updated by ngie:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=4db3872aabc33088cf180599c5eaa23b6f58e6d1
> 
> commit 4db3872aabc33088cf180599c5eaa23b6f58e6d1
> Author:     Enji Cooper <ngie@FreeBSD.org>
> AuthorDate: 2026-07-22 19:33:44 +0000
> Commit:     Enji Cooper <ngie@FreeBSD.org>
> CommitDate: 2026-07-22 19:33:44 +0000
> 
>    Only build secure/libexec/ssh-sk-helper if MK_USB == no
> 
>    The ssh-sk-helper utility only functions if/when MK_USB == yes.
>    Installing it on systems where MK_USB == no doesn't make sense.
> 
>    Differential Revision:  https://reviews.freebsd.org/D58246

	Like kevans correctly noted over IRC, the title line for the commit is backwards: I should have said `if MK_USB != no`, not `if MK_USB == no`.
Thanks,
-Enji


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmphex0ACgkQGpE5DjPs
NJiz7hAAk+uzUT2TMLEYhSKdpw08P5gvMxagCBRxTNM0MSAOkiV/qd3jKONmv8Ff
XDm6aRqY9DPpKpvpOof8N37QBTCWIGc/kwMYp6kN2uY/uBvTepAjzLnRU5tVwIEy
ZXBhtZlgj3hIUPvxz/N1gJgHien/Sx/ouC9yxWESRZaI11GLkwmFMb08JSDza4Gd
atIg8rt0cRO6plgYU1EDgu0hCNjtdYcLYqqmWhqi6rw1x20gPDOUkUYcDGe1EE5B
9nWwpQlpD7RzqKzDD4RdegI/p/3PxRJ3snuuNR8yJ9dXj0GBNTS3fYUxQOWqUq+r
LtOR3Mx5x7VbUPQt7kaY++NwlMzWCxyZbrOt+0ytAhqnggTFjtq95W1kOhxb7eHj
CX24KhtkOIbgFP7gVlHyMxtl3PAZyQ6BrVxpGeCGDDoxw3rOT2secNcb+50jUsRo
7HY1oxdEs55ol/GvNoolYTrReOz4B9tSvL4XIQP++Ypa/+an/3Vs+tiF3stqMxAq
ZlZFqkp6JiiAD6AqM4NMMD3p+SlZcJvbeLrED4s6BUzlyjbZudR8tXmlDAAz5IjY
uDVkWWauyOz72EpI3fqjnfjqMSVt1/hCCWxMiRrDDR92YqCnZwtR+e/A8/HlpEzy
DmFF3lMjKVsYrVQsouA9MnrI8UN8XrWTyhgFTubCtmAo6eZvH+w=
=gOtP
-----END PGP SIGNATURE-----
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7C07696C-0E56-44A5-8AE4-9270891CC973>