Date: Sat, 18 Dec 2010 03:23:24 +0000 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, "Philip M. Gollucci" <pgollucci@FreeBSD.org>, Craig Leres <leres@ee.lbl.gov>, janos.mohacsi@bsd.hu Subject: Re: cvs commit: ports/net/beacon Makefile ports/net/beacon/files beacon.in patch-Makefile.in patch-common-beacon.patch patch-libbeacon-Makefile.in Message-ID: <4D0C292C.5060008@p6m7g8.com> In-Reply-To: <4D0BD3C5.6010809@p6m7g8.com> References: <201012152244.oBFMigGD066775@repoman.freebsd.org> <4D0BCEFA.1030305@FreeBSD.org> <4D0BD3C5.6010809@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/17/10 21:19, Philip M. Gollucci wrote: > On 12/17/10 20:58, Doug Barton wrote: >> Couple of problems with this script. First, since by default it is now >> running as a non-root user it should REQUIRE: LOGIN. We prefer not to >> run code unconditionally, so the if [ -f ${config} ] block should >> probably be in a prestart method. Finally the traditional way of >> daemoninzing is to make command /usr/sbin/daemon, and command_args >> include the thing to start. There are numerous examples of this, it >> should not be too hard to find one. > I will fixes; hopefully today or this weekend. > > Thanks. Learn something new every day about daemon > > Janos, Can you please test this change paying special attention to dougb's additional comment below. http://people.freebsd.org/~pgollucci/beacon.in.txt 03:21 <@dougb> you'll have to test stop and restart with the daemon as command, since I don't think I've done one with both daemon and command_interpreter Thanks. - -- - ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iD8DBQFNDCksdbiP+9ubjBwRApZBAJ9A2Fuu+thZ2FPN+ieBv/nyKiuxRQCeNhew qr9c/qM/siuoi/Ks28SKn1w= =y/aS -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D0C292C.5060008>