Date: Tue, 25 Aug 2009 11:06:18 -0700 From: "Kevin Oberman" <oberman@es.net> To: ahze@freebsd.org Cc: ports@freebsd.org Subject: serpentine port forces dependency on muine Message-ID: <20090825180618.BD0331CC09@ptavv.es.net>
next in thread | raw e-mail | index | archive | help
I have been trying to remove all dependencies on the broken muine port
and discovered that an error in the serpentine port Makefile causes
serpentine to always depend on muine.
The Makefile uses the config option MUINE to indicate whether to build
the muine plugin, but the script then checks "WITH_MUINE" and always
build the muine plugin and creates a dependency on muine.
I have opened PR ports/138179.
I patched the Makefile with:
--- sysutils/serpentine/Makefile.orig 2009-08-25 10:45:24.000000000 -0700
+++ sysutils/serpentine/Makefile 2009-08-25 10:07:00.000000000 -0700
@@ -29,7 +29,7 @@
.include <bsd.port.pre.mk>
-.if (defined(WITH_MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=="i386"
+.if (defined(MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=="i386"
BUILD_DEPENDS+= muine:${PORTSDIR}/audio/muine
RUN_DEPENDS+= muine:${PORTSDIR}/audio/muine
PLIST_SUB+= MUINE=""
This may not be the best way as it overloads the MUINE variable
differently than it is now overloaded, but it looks like it is logically
correct.
The obvious alternative is to add:
.if defined(MUINE)
WITH_MUINE= yes
.endif
--
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net Phone: +1 510 486-8634
Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090825180618.BD0331CC09>