Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Feb 2019 22:26:18 +0000 (UTC)
From:      Eric Joyner <erj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r344643 - head/sys/dev/ixgbe
Message-ID:  <201902272226.x1RMQIf8069172@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: erj
Date: Wed Feb 27 22:26:18 2019
New Revision: 344643
URL: https://svnweb.freebsd.org/changeset/base/344643

Log:
  ixgbe(4): Fix panic triggered by assertion from interrupt
  
  r344162 exposed a bug in one of ixgbe's interrupt filters; they are never
  supposed to return 0. Fix the interrupt filter to return the proper nonzero
  return value.
  
  Reported by:	Oleg Ginzburg <olevole@olevole.ru>
  MFC after:	1 week
  Sponsored by:	Intel Corporation

Modified:
  head/sys/dev/ixgbe/if_ix.c

Modified: head/sys/dev/ixgbe/if_ix.c
==============================================================================
--- head/sys/dev/ixgbe/if_ix.c	Wed Feb 27 22:16:59 2019	(r344642)
+++ head/sys/dev/ixgbe/if_ix.c	Wed Feb 27 22:26:18 2019	(r344643)
@@ -2064,7 +2064,7 @@ ixgbe_msix_que(void *arg)
 
 	/* Protect against spurious interrupts */
 	if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0)
-		return 0;
+		return (FILTER_HANDLED);
 
 	ixgbe_disable_queue(adapter, que->msix);
 	++que->irqs;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902272226.x1RMQIf8069172>