Date: Sun, 21 Nov 2010 13:24:11 +0100 From: Bernhard Schmidt <bschmidt@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r215618 - stable/8/sys/net80211 Message-ID: <201011211324.12283.bschmidt@freebsd.org> In-Reply-To: <20101121112520.GM2392@deviant.kiev.zoral.com.ua> References: <201011211058.oALAwIkp052526@svn.freebsd.org> <20101121112520.GM2392@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 21 November 2010 12:25:20 Kostik Belousov wrote: > On Sun, Nov 21, 2010 at 10:58:18AM +0000, Bernhard Schmidt wrote: > > Author: bschmidt > > Date: Sun Nov 21 10:58:18 2010 > > New Revision: 215618 > > URL: http://svn.freebsd.org/changeset/base/215618 > > > > Log: > > MFC r199076: > > The isr_intval in ieee80211req_scan_result structure should be 16 bit. > > This makes ifconfig list scan display the correct beacon interval > > (previously it would int overflow). As a side effect, this makes the > > ieee80211req_scan_result word aligned. > > > > Submitted by: Paul B Mahol <onemda at gmail.com> > > Committed by: rpaulo > > > > Modified: > > stable/8/sys/net80211/ieee80211_ioctl.h > > > > Directory Properties: > > stable/8/sys/ (props changed) > > stable/8/sys/amd64/include/xen/ (props changed) > > stable/8/sys/cddl/contrib/opensolaris/ (props changed) > > stable/8/sys/contrib/dev/acpica/ (props changed) > > stable/8/sys/contrib/pf/ (props changed) > > stable/8/sys/dev/xen/xenpci/ (props changed) > > > > Modified: stable/8/sys/net80211/ieee80211_ioctl.h > > ========================================================================= > > ===== --- stable/8/sys/net80211/ieee80211_ioctl.h Sun Nov 21 10:56:04 > > 2010 (r215617) +++ stable/8/sys/net80211/ieee80211_ioctl.h Sun Nov 21 > > 10:58:18 2010 (r215618) @@ -790,7 +790,7 @@ struct > > ieee80211req_scan_result { > > > > uint16_t isr_flags; /* channel flags */ > > int8_t isr_noise; > > int8_t isr_rssi; > > > > - uint8_t isr_intval; /* beacon interval */ > > + uint16_t isr_intval; /* beacon interval */ > > > > uint8_t isr_capinfo; /* capabilities */ > > uint8_t isr_erp; /* ERP element */ > > uint8_t isr_bssid[IEEE80211_ADDR_LEN]; > > Doesn't this change ABI ? Yes, it does. While going over the changes I must have mixed that up with struct ieee80211_scan_entry which would have been save you change. Unfortunately that didn't break any of my test setups.. Anyways, I'll revert it. -- Bernhard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011211324.12283.bschmidt>