Date: Wed, 17 Mar 2004 03:40:29 -0800 From: Kris Kennaway <kris@obsecurity.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/gcc34 Makefile Message-ID: <20040317114028.GA62685@xor.obsecurity.org> In-Reply-To: <20040317112344.GB86662@dragon.nuxi.com> References: <200403170818.i2H8IFYU008824@repoman.freebsd.org> <Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at> <Pine.BSF.4.58.0403171135480.94079@acrux.dbai.tuwien.ac.at> <20040317112344.GB86662@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 17, 2004 at 03:23:44AM -0800, David O'Brien wrote: > On Wed, Mar 17, 2004 at 11:50:52AM +0100, Gerald Pfeifer wrote: > > I'm afraid I know. Your commit apparently broke the port an all platfo= rms > > but amd64. :-( > >=20 > > Have you tested this following the instructions at > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port= ing-testing.html > > ? For invasive changes like this, I'd like to ask you to always test at > > least i386 when committing changes to ports that I maintain. >=20 > I *DID* test on i386 (5.2-CURRENT, full 'make world' just before testing > the port). Do you have additional bsd.port.mk patches in your tree? The comment in your commit log about bsd.port.mk now using a different default value of CONFIGURE_TARGET seemed odd to me - there were patches proposed to change this, but they were never committed because they broke a lot of ports. Kris --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAWDksWry0BWjoQKURAs8rAJ0WDdIrItvuRKK5OTABiAL9IubV1QCeI8HI x6pDfK9EqdE+zQNwY+EJ47w= =iqZj -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040317114028.GA62685>