Date: Sat, 23 Jan 2010 14:55:02 GMT From: jhell <jhell@DataIX.net> To: freebsd-gnats-submit@FreeBSD.org Subject: conf/143127: Patch against newvers.sh, minor cleanup/fixes Message-ID: <201001231455.o0NEt26w067164@www.freebsd.org> Resent-Message-ID: <201001231500.o0NF09aY062464@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 143127
>Category: conf
>Synopsis: Patch against newvers.sh, minor cleanup/fixes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 23 15:00:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: jhell
>Release: 7.2-STABLE Latest
>Organization:
>Environment:
Before Patch:
FreeBSD 7.2-STABLE #0 r202861M: Fri Jan 22 21:38:37 EST 2010 i386
With the patch:
FreeBSD 7.2-STABLE #0 r202861M Fri Jan 22 21:38:37 EST 2010 i386
Non relevant sections of uname removed.
>Description:
Remove unneeded ":" delimiter. Nothing else has a delimiter in the
version string so why have one at all ?. This effects extra needed
parsing efforts when svnversion turns into "rREV:REV".
Convert four spaces to one space+tab. I believe this used to be a
space+tab but was turned into spaces due to copy & paste.
>How-To-Repeat:
Revert/Update sections of code or other files to a previous revision than what the tree is at. This will give you rREV:REV in any built kernels uname.
>Fix:
Patch attached.
Patch attached with submission follows:
Author: jhell@dataix.net
Date: Thu Jan 21 22:42:37 UTC 2010
Log:
Remove unneeded ":" delimiter. Nothing else has a delimiter in the
version string so why have one at all ?. This effects extra needed
parsing efforts when svnversion turns into "rREV:REV".
Convert four spaces to one space+tab. I believe this used to be a
space+tab but was turned into spaces due to copy & paste.
Modified:
stable/7/sys/conf/newvers.sh
Modified: stable/7/sys/conf/newvers.sh
===================================================================
--- /usr/src/sys/conf/newvers.sh (revision 202769)
+++ /usr/src/sys/conf/newvers.sh (working copy)
@@ -135,8 +135,8 @@
cat << EOF > vers.c
$COPYRIGHT
-#define SCCSSTR "@(#)${VERSION} #${v}${svn}${git}: ${t}"
-#define VERSTR "${VERSION} #${v}${svn}${git}: ${t}\\n ${u}@${h}:${d}\\n"
+#define SCCSSTR "@(#)${VERSION} #${v}${svn}${git} ${t}"
+#define VERSTR "${VERSION} #${v}${svn}${git} ${t}\\n ${u}@${h}:${d}\\n"
#define RELSTR "${RELEASE}"
char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001231455.o0NEt26w067164>