Date: Tue, 09 Aug 2005 13:14:24 +0400 From: Vsevolod Stakhov <vsevolod@FreeBSD.org> To: Sergey Matveychuk <sem@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: bsd.database.mk suggestion Message-ID: <42F873F0.7060708@FreeBSD.org> In-Reply-To: <42F85865.3010406@FreeBSD.org> References: <20050808113340.GD71954@spray.anyhost.ru> <42F85865.3010406@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sergey Matveychuk wrote: > Vsevolod Stakhov wrote: > >> Hi, >> >> I think bsd.database.mk is now more or less ready. But I want >> to listen your comments about it. Now I've moved all mysql/pgsql >> related stuff from bsd.port.mk to bsd.database.mk and added >> bdb handling and sqlite dependency. > > > A symantics for variables is differ. I'm not sure it's a good thing. > E.g. > USE_MYSQL - yes|undefined > WANT_MYSQL_VER - mysql version a maintainer wants > WITH_MYSQL_VER - mysql version an user wants > The same for PostgreSQL. > > But you use USE_DBD_VER= yes|version. > USE_DBD_VER=yes is weird. > > <IMHO> > I dislike _VER suffix for USE_FOO. > Well, I dislike WANT_FOO too. I think it's a surcharge. > > I like this scheme: > USE_SOMEDB= yes|version Yes, I like this too. But it can confuse those people that are common to mysql/pgsql semantics. On the other hand bdb differs from mysql/pgsql as its version are not conflicting. So things like USE_BDB= yes and WANT_BDB_VER are not a good idea. USE_BDB= yes|version sounds nice, I think. > It's just like USE_GCC do. > </IMHO>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42F873F0.7060708>