Date: Thu, 21 Nov 2019 21:11:27 +0000 From: Brooks Davis <brooks@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org>, Colin Percival <cperciva@freebsd.org> Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191121211127.GC50024@spindle.one-eyed-alien.net> In-Reply-To: <20191121161337.GA92849@FreeBSD.org> References: <201911201836.xAKIawWt053874@repo.freebsd.org> <20191121161337.GA92849@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 04:13:37PM +0000, Glen Barber wrote: > On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > > Author: brooks > > Date: Wed Nov 20 18:36:58 2019 > > New Revision: 354909 > > URL: https://svnweb.freebsd.org/changeset/base/354909 > >=20 > > Log: > > Make the warning for deprecated NO_ variables an error. > > =20 > > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFILE, > > and NO_WARNS as deprecated in 2014 with a warning added for each one > > found. Turn these into error in preperation for removal of compatabil= ity > > support before FreeBSD 13. > > =20 > > Reviewed by: imp > > Relnotes: yes > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D22448 > >=20 >=20 > > Modified: head/share/mk/bsd.opts.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908) > > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909) > > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > PROFILE \ > > WARNS > > .if defined(NO_${var}) > > -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > +.error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > > MK_${var}:=3Dno > > .endif > > .endfor > >=20 >=20 > Had this been exp-run tested? This breaks at least the > net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in > its Makefile. I suspect at least several other ports are now implicitly > broken as result of this change. No, it wasn't. I didn't realize it was needed. I could revert if there's significant fallout. I've patched net/bsdec2-image-upload and I'm testing a patch for emulators/open-vm-tools. In general the issue is people putting NO_MAN=3D in Makefiles that the freebsd build infrastructure and then never looking at build output. In some cases it's clearly blind copy-and-paste (e.g. emulators/open-vm-tools sets NO_MAN and NOMAN in a kmod Makefile where they do nothing). Ideally I'd like to suppress these errors in ports unless DEVELOPER is defined, but I'm not sure how best to do that. -- Brooks --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJd1v1/AAoJEKzQXbSebgfAGcMH/16GvoPgZCr65wRJ8bMeAmcV XL1PNd2kP7h/J6dPeWWVAEOh26FspYBzhu93hMDd1qcNqiHHT3HzDvsLaTaR+YJQ kyL9KytRC+XzFad5YgW0Q403u+P88jgQtllHvJm++Z79Rj732B18gKrggEnfTfUu 8MAb8jgaGRXrmaKCtbmHfeloiz2FPBXJh7mlG5Gf8sWonvKF6rzEfc4yRI04JnSn CNFIqeG6CGld0DP15oYNGzTdYvZC7kkF7DvFfKn0ilaquu4D22JF5he1KHG9JdxA 4/+tmw+xvRDTJKOg32YQr5Sc5NHFwW/tUIE97V4QQ441P68zcStd764791LdRu8= =wzRv -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191121211127.GC50024>