Date: Thu, 18 Dec 2014 14:44:47 -0700 From: Warner Losh <wlosh@netflix.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: Ed Schouten <ed@80386.nl>, src-committers@freebsd.org, svn-src-all@freebsd.org, Dimitry Andric <dim@FreeBSD.org>, svn-src-head@freebsd.org, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src Message-ID: <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com> In-Reply-To: <20141217211654.GA95193@troutmask.apl.washington.edu> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <CAJOYFBAAe_3psxdDC1Oq0%2BW=9T4qnSDK=tST3pP6q1iBpgME1w@mail.gmail.com> <20141217191235.GA89501@troutmask.apl.washington.edu> <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> <20141217211654.GA95193@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 17, 2014, at 2:16 PM, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: > > > Ed's diff is ~1000 lines and touches several files. Localizing > the change to math_private.h would have been a ~20 line > diff to a single file. Then just back his change out, put yours in and we all win. This seems like ample “this is better” justification to me. While there is a little more churn, external trackers will apply then unapply the churn, resulting in a net win. Especially if you do the blackout as one commit and the better fix as another, which means external trackers can just skip the two commits of churn with little effort on their part. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18504F2A-72C1-4962-86E6-CCAE4898B478>