Date: Mon, 22 Jan 2007 16:57:18 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Rene Ladan <r.c.ladan@gmail.com> Cc: fs@freebsd.org Subject: Re: unused code in msdosfs_lookup.c ? Message-ID: <20070122145718.GC71333@deviant.kiev.zoral.com.ua> In-Reply-To: <45B4C71B.1030408@gmail.com> References: <45B4C71B.1030408@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jan 22, 2007 at 03:15:55PM +0100, Rene Ladan wrote: > Hi, > > while working on the XTAF fs module (see the archives), I discovered > that the code path in the lookup() routine which deals with > cnp->cn_nameptr being "." or ".." is never used. > > To verify this, I added a printf() to the analogous code in > sys/fs/msdosfs/msdosfs_lookup.c (lines 134-145, revision 1.47), but the > following commands could not trigger the code: > > % ls . > % ls .. > % file . > % file ../. > % hd . > % hd .. > % cd .. > % cd ../a/b > % ls -laoT . > % du /mountpoint > > This code fakes the "." and ".." entries in the root directory of msdos > filesystems, which are otherwise absent. > > So it seems like that code was either never tested or something in the > calling code changed (which would be cachedlookup() in VOP layer). > > Ideas? See, for instance, kern/92785. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFtNDNC3+MBN1Mb4gRApCbAKC4adIYJSoAf3c+WNZXy6Nvns/wFQCfbbja RVBG/BIWGprZS3wOBgH8IyE= =U64V -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070122145718.GC71333>