Date: Thu, 13 Feb 2020 20:45:32 +0000 (UTC) From: Alan Somers <asomers@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r357879 - stable/12/usr.sbin/extattr Message-ID: <202002132045.01DKjWML005824@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: asomers Date: Thu Feb 13 20:45:32 2020 New Revision: 357879 URL: https://svnweb.freebsd.org/changeset/base/357879 Log: MFC r356809: setextattr: Increase stdin buffer size to 4096 Extended attribute values can potentially be quite large. One test for ZFS is supposed to set a 200MB xattr. However, the buffer size for reading values from stdin with setextattr -i is so small that the test times out waiting for tiny chunks of data to be buffered and appended to an sbuf. Increasing the buffer size should help alleviate some of the burden of reallocating larger sbufs when writing large extended attributes. Submitted by: Ryan Moeller <ryan@freqlabs.com> Sponsored by: iXsystems, Inc. Differential Revision: https://reviews.freebsd.org/D23211 Modified: stable/12/usr.sbin/extattr/rmextattr.c Directory Properties: stable/12/ (props changed) Modified: stable/12/usr.sbin/extattr/rmextattr.c ============================================================================== --- stable/12/usr.sbin/extattr/rmextattr.c Thu Feb 13 20:41:20 2020 (r357878) +++ stable/12/usr.sbin/extattr/rmextattr.c Thu Feb 13 20:45:32 2020 (r357879) @@ -104,7 +104,7 @@ mkbuf(char **buf, int *oldlen, int newlen) int main(int argc, char *argv[]) { -#define STDIN_BUF_SZ 1024 +#define STDIN_BUF_SZ 4096 char stdin_data[STDIN_BUF_SZ]; char *p;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002132045.01DKjWML005824>