Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Feb 2006 10:01:43 +0100
From:      Morten Rodal <morten@rodal.no>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/em if_em.c
Message-ID:  <20060221090143.GB33896@burton.rodal.no>
In-Reply-To: <200602151345.k1FDj2Aq013830@repoman.freebsd.org>
References:  <200602151345.k1FDj2Aq013830@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--0eh6TmSyL6TZE2Uz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 15, 2006 at 01:45:02PM +0000, Gleb Smirnoff wrote:
> glebius     2006-02-15 13:45:02 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/dev/em           if_em.c=20
>   Log:
>   em_hardware_init() in em_init() is not needed, and leads to annoying
>   link flap.
>  =20
>   Submitted by:   ru, Mike Tancsa
>  =20
>   Revision  Changes    Path
>   1.112     +0 -7      src/sys/dev/em/if_em.c

This change breaks the network interfaces in vmware 5.5 on amd64.  I
also attempted to build a module with NO_EM_FASTINTR defined, but that
did not help either.  The change in 1.113 has no effect either.

Reverting the em_hardware_init() change works, even without the
em_update_link_status().

--=20
Morten Rodal

"A supercomputer is a device for turning compute-bound
 problems into I/O bound problems." -- Ken Batcher (Goodyear Aerospace)


--0eh6TmSyL6TZE2Uz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQFD+tb3bWe1Cy11WVsRAsfzAJoDC67vpIctvYaDCSdBF688/nARoACdEnMF
0PgNEpThj06BYXKnMV/pKrY=
=volQ
-----END PGP SIGNATURE-----

--0eh6TmSyL6TZE2Uz--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060221090143.GB33896>