Date: Thu, 29 Sep 2005 08:37:47 -0700 From: Sam Leffler <sam@errno.com> To: Peter Edwards <peadar.edwards@gmail.com> Cc: Peter Edwards <peadar@FreeBSD.org>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c Message-ID: <433C0A4B.8030504@errno.com> In-Reply-To: <34cb7c84050929064918862231@mail.gmail.com> References: <200509291037.j8TAbKdI010227@repoman.freebsd.org> <20050929130338.GC1715@garage.freebsd.pl> <34cb7c84050929064918862231@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Edwards wrote: > On 9/29/05, Pawel Jakub Dawidek <pjd@freebsd.org> wrote: > >>On Thu, Sep 29, 2005 at 10:37:20AM +0000, Peter Edwards wrote: >>+> peadar 2005-09-29 10:37:20 UTC >>+> >>+> FreeBSD src repository >>+> >>+> Modified files: >>+> sys/kern vfs_bio.c >>+> Log: >>+> Close a race in biodone(), whereby the bio_done field of the passed >>+> bio may have been freed and reassigned by the wakeup before being >>+> tested after releasing the bdonelock. >>+> >>+> There's a non-zero chance this is the cause of a few of the crashes >>+> knocking around with biodone() sitting in the stack backtrace. >> >>Should this fix the panic on boot in vmware? >> > > > That one falls under the "non-zero chance" mentioned above :-) The > problem was very intermittent for me, and wanting the laptop not to > fall over seemed to be a prerequisite to reproducing the panic, so I > can't positively say it's fixed the problem yet. > > If you have a reliable way of reproducing the panic, can you try out > the patch and let me know? vmware is great for finding races like these because of the way it handles concurrency. I can remember finding many problems like this in "client operating systems" when I worked on it. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?433C0A4B.8030504>