Date: Wed, 25 Feb 2009 20:42:28 +0100 From: Ed Schouten <ed@80386.nl> To: Robert Noland <rnoland@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189052 - head/sys/dev/drm Message-ID: <20090225194228.GS19161@hoeg.nl> In-Reply-To: <200902251854.n1PIsZZP005285@svn.freebsd.org> References: <200902251854.n1PIsZZP005285@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi Robert,
* Robert Noland <rnoland@FreeBSD.org> wrote:
> +static struct drm_msi_blacklist_entry drm_msi_blacklist[] = {
> + {0x8086, 0x2772}, /* Intel i945G */ \
> + {0x8086, 0x27A2}, /* Intel i945GM */ \
> + {0x8086, 0x27AE}, /* Intel i945GME */ \
> + {0, 0}
> +};
Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
definitions here?
--
Ed Schouten <ed@80386.nl>
WWW: http://80386.nl/
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkmlnyMACgkQ52SDGA2eCwWvIQCfbuGlEs2h5aaoWDPFuJ+vTiQj
a+gAn0a97CLRCyUAwikJHoDydtt8Xmeb
=xKec
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090225194228.GS19161>