Date: Tue, 29 Mar 2022 08:54:36 +0200 From: =?UTF-8?q?Corvin=20K=C3=B6hne?= <c.koehne@beckhoff.com> Cc: =?UTF-8?q?Corvin=20K=C3=B6hne?= <c.koehne@beckhoff.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, Gerd Hoffmann <kraxel@redhat.com>, Rebecca Cran <rebecca@bsdio.com>, Peter Grehan <grehan@freebsd.org>, <devel@edk2.groups.io>, FreeBSD Virtualization <freebsd-virtualization@freebsd.org> Subject: [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support Message-ID: <20220329065437.186-1-c.koehne@beckhoff.com>
next in thread | raw e-mail | index | archive | help
=EF=BB=BFHi, I'm going to add QemuFwCfg support to bhyve. See https://reviews.freebsd.org/D31578. Therefore, this patch for OVMF is neccessary to work properly. There's one open point on that patch and hopefully one of you has more insights. Qemu has an item called FW_CFG_MAX_CPUS. It looks very similar to what we need here, but I'm not sure if we can use it safely as Qemu has a comment about it: https://github.com/qemu/qemu/blob/0021c4765a6b83e5b09409b75d50c6caaa6971b9/= hw/i386/fw_cfg.c#L110-L121 /* FW_CFG_MAX_CPUS is a bit confusing/problematic on x86: * * For machine types prior to 1.8, SeaBIOS needs FW_CFG_MAX_CPUS for * building MPTable, ACPI MADT, ACPI CPU hotplug and ACPI SRAT table, * that tables are based on xAPIC ID and QEMU<->SeaBIOS interface * for CPU hotplug also uses APIC ID and not "CPU index". * This means that FW_CFG_MAX_CPUS is not the "maximum number of CPUs", * but the "limit to the APIC ID values SeaBIOS may see". * * So for compatibility reasons with old BIOSes we are stuck with * "etc/max-cpus" actually being apic_id_limit */ Thanks Corvin CC: Ard Biesheuvel <ardb+tianocore@kernel.org> CC: Jiewen Yao <jiewen.yao@intel.com> CC: Jordan Justen <jordan.l.justen@intel.com> CC: Gerd Hoffmann <kraxel@redhat.com> CC: Rebecca Cran <rebecca@bsdio.com> CC: Peter Grehan <grehan@freebsd.org> CC: devel@edk2.groups.io CC: FreeBSD Virtualization <freebsd-virtualization@freebsd.org> Corvin K=C3=B6hne (1): OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 41 +++++++++++++++++++= +--- OvmfPkg/Bhyve/BhyveX64.dsc | 4 +-- 3 files changed, 40 insertions(+), 6 deletions(-) --=20 2.11.0 Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220329065437.186-1-c.koehne>