Date: Tue, 18 May 1999 16:46:39 -0500 (EST) From: Alfred Perlstein <bright@rush.net> To: current@freebsd.org Subject: nodump is not a dump routine. Message-ID: <Pine.BSF.3.96.990518163845.26546I-100000@cygnus.rush.net>
next in thread | raw e-mail | index | archive | help
i'm wondering why when the system dumpdev is set to a device that
doesn't have a read dump routine (nodump()) why it lies about the
dump being successful.
Index: kern_shutdown.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_shutdown.c,v
retrieving revision 1.52
diff -u -r1.52 kern_shutdown.c
--- kern_shutdown.c 1999/05/12 22:30:46 1.52
+++ kern_shutdown.c 1999/05/19 00:38:43
@@ -387,6 +387,10 @@
printf("dump ");
switch ((*bdevsw(dumpdev)->d_dump)(dumpdev)) {
+ case ENODEV:
+ printf("device has no dump routine\n");
+ break;
+
case ENXIO:
printf("device bad\n");
break;
shouldn't
src/sys/i386/i386/autoconf.c, and
src/sys/alpha/alpha/autoconf.c decline to set the dump device
to a device that has nodump() as its dump routine?
With the recent udev_t <-> dev_t changes and alpha not being in
sync with it (or so it seems) I don't feel comfortable suggesting
a patch for it, even though it appears to be quite simple.
one other question, considering the newbus stuff, shouldn't
there be a way to get the text string of the dump device somehow
so "dumpon" with no arguments can print out the current value
without scanning /dev for a device that matches it?
or does that still have to wait for devfs?
thanks,
-Alfred
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990518163845.26546I-100000>