Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Aug 2012 02:34:51 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Paul Ambrose <ambrosehua@gmail.com>
Cc:        freebsd-mips@freebsd.org
Subject:   Re: SYSCTL_INT emulate_fp error
Message-ID:  <76EA6699-96FB-4616-BFBB-F274680CFCAB@bsdimp.com>
In-Reply-To: <CAMwoQQ5Yt9w8d1_K-mwQECZL0S-tyYAewPGrRYoNQXe=2b4P0g@mail.gmail.com>
References:  <CAMwoQQ5Yt9w8d1_K-mwQECZL0S-tyYAewPGrRYoNQXe=2b4P0g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Aug 7, 2012, at 1:13 AM, Paul Ambrose wrote:
> When I read sys/mips/mips/trap.c,  I found
> /*
> * FP emulation is assumed to work on O32, but the code is outdated and
> crufty
> * enough that it's a more sensible default to have it disabled when using
> * other ABIs.  At the very least, it needs a lot of help in using
> * type-semantic ABI-oblivious macros for everything it does.
> */
> #if defined(__mips_o32)
> static int emulate_fp = 1;
> #else
> static int emulate_fp = 0;
> #endif
> SYSCTL_INT(_machdep, OID_AUTO, emulate_fp, CTLFLAG_RW,
>    &allow_unaligned_acc, 0, "Emulate unimplemented FPU instructions");
> 
>  here &allow_unaligned_acc should be  &emulate_fp

You're right.  Fixed.

Warner




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76EA6699-96FB-4616-BFBB-F274680CFCAB>