Date: Thu, 21 Sep 2006 12:10:21 +0200 From: Maxime Henrion <mux@FreeBSD.org> To: Ian Dowse <iedowse@iedowse.com> Cc: re@freebsd.org, freebsd-usb@freebsd.org Subject: Re: ehci.c : uncommited patch fixes DRAC5 problems Message-ID: <20060921101021.GU23052@elvis.mu.org> In-Reply-To: <200609202108.aa33040@nowhere.iedowse.com> References: <20060919174541.7afc5f47.wmoran@collaborativefusion.com> <200609202108.aa33040@nowhere.iedowse.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ian Dowse wrote: > In message <20060919174541.7afc5f47.wmoran@collaborativefusion.com>, Bill Moran > writes: > > > >http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/ehci.c?rev=1.42&content- > >type=text/x-cvsweb-markup > > > >I'm one of those people who've been having trouble with Dell's > >DRAC5 keyboards not working in 6.1. Grabbing the above > >version of ehci.c fixes the problem (except that I had to > >comment out line 766) > > > >The commit note suggests that this should have been MFCed back > >in April. Can we get this MFCed before 6.2 comes out? > > I can MFC revisions 1.42 and 1.43 if re@ agrees (cc'd). It's a > fairly self-contained change, and I don't think there were any > reports of this breaking things things in -current as far as I can > remember. Fair enough. I think this should go in, so consider this approved, unless other re@ members voice in and are opposed to this. However, I think we should be extra careful with this once since it's a rather central and important piece of code for many people, and as far as I can tell, this patch has the side-effect of trusting the hardware more than before. We've had a rather bad history of trusting hardware :-). Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060921101021.GU23052>