Date: Wed, 31 Jan 2024 09:40:30 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dmitry Salychev <dsl@mcusim.org> Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 Message-ID: <20240131174030.8787610F@slippy.cwsent.com> In-Reply-To: <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org> References: <202401310406.40V46B9a000876@gitrepo.freebsd.org> <thik6e6mp53h242l6bhgyxkzl45jne5zhxb7retxgyvot3x6jq@v2yuxtpvczg7> <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, Jung-uk Kim writ es: > On 24. 1. 31., Baptiste Daroussin wrote: > > Hello, > > > > Either this one or the previous import is breaking arm64 build > > > > --- acpi_iort.o --- > > /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error: field > > 'data' with variable sized type 'union (unnamed union at > > /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 > > )' not at the end of a struct or class is a GNU extension > > [-Werror,-Wgnu-variable-sized-type-not-at-end] > > 103 | } data; > > | ^ > > Sorry for the breakage. I will fix it soon. > > BTW, this code was added by this: > > https://reviews.freebsd.org/D31267 > > It seems struct iort_named_component was a hack, which duplicated > ACPI_IORT_NAMED_COMPONENT but with a fixed length field DeviceName[32]. > Is it really necessary? Though they incorporated the WOL patch I've been using, they've broken poweroff. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240131174030.8787610F>