Date: Fri, 19 Dec 2008 16:47:48 +0100 From: Ed Schouten <ed@80386.nl> To: Ivan Voras <ivoras@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186322 - head/sys/kern Message-ID: <20081219154748.GC1176@hoeg.nl> In-Reply-To: <200812191449.mBJEnFOb074699@svn.freebsd.org> References: <200812191449.mBJEnFOb074699@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qN286NIOm1dtEdh0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ivan, * Ivan Voras <ivoras@FreeBSD.org> wrote: > Reviewed by: ed (older version) As you mentioned, I didn't review this version. Like I said, I don't have strong opinions on the subject, but: > Modified: head/sys/kern/tty.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/tty.c Fri Dec 19 14:47:38 2008 (r186321) > +++ head/sys/kern/tty.c Fri Dec 19 14:49:14 2008 (r186322) > @@ -871,9 +871,9 @@ tty_alloc(struct ttydevsw *tsw, void *sc > =20 > tty_init_termios(tp); > =20 > - cv_init(&tp->t_inwait, "ttyinput"); > - cv_init(&tp->t_outwait, "ttyoutput"); > - cv_init(&tp->t_bgwait, "ttybackground"); > + cv_init(&tp->t_inwait, "ttyinp"); > + cv_init(&tp->t_outwait, "ttyout"); > + cv_init(&tp->t_bgwait, "ttybgw"); > cv_init(&tp->t_dcdwait, "ttydcd"); If we're renaming them to <=3D6-character strings, maybe it's better to use "ttyin" and "ttybg"? The old TTY code used these strings as well. I've also got a small preference of "ttymtx" over "ttylck". "ttymtx" makes it more clear it is blocked on the mutex, while "lck" could be literally any form of locking (file locking?). --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --qN286NIOm1dtEdh0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklLwiQACgkQ52SDGA2eCwVwJQCeMLrpFA7R1l4BUP50ALjcE8na jpcAn2jX4g3gnWpiZQ9n4AGHyWl6cgPh =6IDB -----END PGP SIGNATURE----- --qN286NIOm1dtEdh0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081219154748.GC1176>