Date: Thu, 1 Feb 2007 09:46:03 +0000 (UTC) From: Ariff Abdullah <ariff@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/sound/pcm buffer.c buffer.h Message-ID: <200702010946.l119k4oO049443@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ariff 2007-02-01 09:46:03 UTC
FreeBSD src repository
Modified files:
sys/dev/sound/pcm buffer.c buffer.h
Log:
Fix huge memory leak within sound buffer (during channel destruction,
buffer resizing, etc.) that was here since eon. Free all (unmanaged)
allocated buffer through sndbuf_destroy() in case we forgot to call
sndbuf_free(). For a managed buffer (mostly hw specific managed buffer),
either provide CHANNEL_FREE() method with appropriate return value to
invoke semi-automatic sndbuf_free() or simply do it on their own. If
everything is failed, sndbuf_destroy() will come to the rescue as a
final measure.
MFC after: 3 days
Revision Changes Path
1.30 +12 -0 src/sys/dev/sound/pcm/buffer.c
1.14 +1 -0 src/sys/dev/sound/pcm/buffer.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702010946.l119k4oO049443>