Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Feb 2008 20:50:38 +0200
From:      "Niki Denev" <nike_d@cytexbg.com>
To:        "Matteo Riondato" <matteo@freebsd.org>, cvs-src@freebsd.org
Subject:   Re: cvs commit: src/sbin/mount mount.c
Message-ID:  <2e77fc10802031050g447639eu6dad5f025002886f@mail.gmail.com>
In-Reply-To: <20080203183150.GB17218@kaiser.sig11.org>
References:  <200802031723.m13HNwXv021645@repoman.freebsd.org> <2e77fc10802030954y2facd678v90309332e427111e@mail.gmail.com> <20080203183150.GB17218@kaiser.sig11.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 3, 2008 8:31 PM, Matteo Riondato <matteo@freebsd.org> wrote:
> On Sun, Feb 03, 2008 at 07:54:28PM +0200, Niki Denev wrote:
> > mount(8) has also "-p" option problems with gjournal-ed filesystems.
> > The same problems prevents mount updates with option "current" too,
> > i.e. "mount -u -ocurrent,noatime /gjournaledfs"
> > Here is a PR about this : http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/120162
>
> Err, reply to self:
> The problem with -ocurrent still exists, while the problem with -p is
> gone.
> I'll try to work on it, thanks.
>
> --
> Matteo Riondato
> FreeBSD Committer (http://www.FreeBSD.org)
> FreeSBIE Developer (http://www.FreeSBIE.org)
> GUFI Staff Member (http://www.GUFI.org)
>

Hi,

I'm running with version 1.96 of mount.c and both problems still exist :

  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs
async,noatime,gjournal  1 1

  server# mount -u -oatime,current /
  mount: mount option <gjour : Invalid argument

With the patch that I supplied in the PR the behaviour looks correct :

  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs     async,noatime   1 1

  server# mount -u -o current,atime /
  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs     async           1 1


--Niki



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2e77fc10802031050g447639eu6dad5f025002886f>