Date: Wed, 13 Jun 2018 17:01:35 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335042 - head/usr.bin/top Message-ID: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> In-Reply-To: <201806130852.w5D8qKd4094584@repo.freebsd.org> References: <201806130852.w5D8qKd4094584@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2 Content-Type: multipart/mixed; boundary="ATlQM6y8g3RNle56kKvDtVw76tSh0GFat"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> Subject: Re: svn commit: r335042 - head/usr.bin/top References: <201806130852.w5D8qKd4094584@repo.freebsd.org> In-Reply-To: <201806130852.w5D8qKd4094584@repo.freebsd.org> --ATlQM6y8g3RNle56kKvDtVw76tSh0GFat Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/13/2018 1:52 AM, Eitan Adler wrote: > Author: eadler > Date: Wed Jun 13 08:52:19 2018 > New Revision: 335042 > URL: https://svnweb.freebsd.org/changeset/base/335042 >=20 > Log: > top(1): add myself to authors > =20 > At this point I've mucked enough with top(1) that all bugs should be > blamed on me rather than William LeFebvre. >=20 Thank you for all of your work here... There's not exactly a guideline for this but I don't feel that non-functional changes qualify as "authors". Especially the sorting chosen. Perhaps I missed some rewrite you've done? Though none have 'Relnotes: yes' so I am assuming they were all non-functional. There's been 62 unique committers to usr.bin/top, which does not account for Submitted By. All of which are also missing from AUTHORS and Copyrigh= ts. I do see some people adding their Copyright on some commits but overall we haven't done that as a project and I am curious if we should change in that regard. Also I really abhor rewriting anything that's not broken as it causes merge conflict pain downstream and just adds regression risk. > Modified: > head/usr.bin/top/top.1 > head/usr.bin/top/utils.c >=20 > Modified: head/usr.bin/top/top.1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/top/top.1 Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/top.1 Wed Jun 13 08:52:19 2018 (r335042) > @@ -360,6 +360,7 @@ process is waiting. > Lock names are prefixed with an asterisk \*(lq*\*(rq while sleep event= s > are not. > .Sh AUTHORS > +.An Eitan Adler Aq Mt eadler@FreeBSD.org > .An William LeFebvre, EECS Department, Northwestern University > .Sh BUGS > The command name for swapped processes should be tracked down, but thi= s >=20 > Modified: head/usr.bin/top/utils.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/top/utils.c Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/utils.c Wed Jun 13 08:52:19 2018 (r335042) > @@ -2,6 +2,7 @@ > * This program may be freely redistributed, > * but this entire comment MUST remain intact. > * > + * Copyright (c) 2018, Eitan Adler > * Copyright (c) 1984, 1989, William LeFebvre, Rice University > * Copyright (c) 1989, 1990, 1992, William LeFebvre, Northwestern Uni= versity > * >=20 --=20 Regards, Bryan Drewery --ATlQM6y8g3RNle56kKvDtVw76tSh0GFat-- --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbIbBrAAoJEDXXcbtuRpfPnw4H/3sf5fNiUbb7aeLwQIXNs9k/ oBPKHDX+iNW0MP7HIDPJKFAg7lkC2Tnxkld0HpV2W/Tijp/JLgWc0lBTiEfdVDk0 /Z5Bl/zaQm9fml8p9CIeK3eJTorptcO883aKFVK8veMdMb0QwMpfsGBWu+MYAxKq ykvRgsDlH/IU1Ja/ird7+/VqF1iyGCSYQffZ/RXr2IIsv6lFtrQ9G5ytCQSG0RYJ MY13gI8n0Lpnp0J5YGeZ11qOmr6u8Em25XLdHO4Xaj1aTRPT5RgcN9rVRogCSv41 6aB8I+e3WHmuNcqJXvuSOyUdGO/elEDDQrC36m/XdJkJeMmHRc9Se3xYgPBoT7E= =3k1a -----END PGP SIGNATURE----- --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9>