Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Feb 2024 14:51:28 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 23d4d0fcc1be - main - pmc: Fix some problems with the makefile
Message-ID:  <202402161451.41GEpSwE016168@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=23d4d0fcc1be3d2f44054dd12725098ac7ee34a9

commit 23d4d0fcc1be3d2f44054dd12725098ac7ee34a9
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-02-15 18:17:37 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-02-16 14:50:43 +0000

    pmc: Fix some problems with the makefile
    
    - For some reason we don't build it as a PIE, but I don't have any
      problems doing so with either clang or gcc.
    - There is no apparent need to override WARNS, so don't.
    - Some building with -O0, presumably that's left over from debugging.
    
    MFC after:      1 week
    Reviewed by:    imp, brooks
    Sponsored by:   Klara, Inc.
    Differential Revision:  https://reviews.freebsd.org/D43923
---
 usr.sbin/pmc/Makefile | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/usr.sbin/pmc/Makefile b/usr.sbin/pmc/Makefile
index dda72c85a106..3f73dd398958 100644
--- a/usr.sbin/pmc/Makefile
+++ b/usr.sbin/pmc/Makefile
@@ -1,18 +1,11 @@
-#
-#
-
 .include <src.opts.mk>
+
 PROG_CXX=	pmc
 MAN=	
-WARNS?=	3
-CXXFLAGS+= -O0
 CXXSTD= c++14
 CWARNFLAGS.gcc+= -Wno-redundant-decls
 CFLAGS+= -I${SRCTOP}/lib/libpmcstat
 
-# Does not link when built position-independent.
-MK_PIE=no
-
 LIBADD=	pmc m pmcstat elf
 
 SRCS=	pmc.c pmc_util.c cmd_pmc_stat.c \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202402161451.41GEpSwE016168>