Date: Wed, 1 May 1996 06:21:03 +1000 From: Bruce Evans <bde@zeta.org.au> To: jkh@time.cdrom.com, wosch@cs.tu-berlin.de Cc: current@freebsd.org Subject: Re: Files installed to /etc, (was: review request) Message-ID: <199604302021.GAA21324@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>1. some Makefile use 'mv' without option '-f'. This may fail mv(1) > into interactive mode if you are not root and the destination > file is write protected. >$ touch a b; chmod 444 a b; /bin/mv a b >override r--r--r-- wosch/wheel for b? ;-(( Install usually has to be run by root so that it can chown the target, so this shouldn't be a problem. >Solution: a variable MV="mv -f" in sys.mk >2. Same problem for 'rm', use variable RM="rm -f"in sys.mk I'd prefer to avoid this (and to someday avoid my ECHO and INSTALL macros :-). >3. Wired /usr/share/mk/sys.mk. make -I <dir> do not change the > directory for sys.mk. We need this for ``make DESTDIR=/foo world'' > so /foo/usr/share/mk/sys.mk would be used. >Does someone test the following patch? >... >-#define _PATH_DEFSYSMK "/usr/share/mk/sys.mk" >+#define _PATH_DEFSYSMK "sys.mk" > #define _PATH_DEFSYSPATH "/usr/share/mk" I thought that you said this was only a temporary fix when we talked about it in private mail. What gets used if sys.mk is in "." and in paths specified by -I? I think ./sys/mk should only be used if "-I." is used. >4. A target for executable scripts Yes, this has been delayed too long. 5. A target for miscellaneous files. This has also been delayed too long. 6. Think about avoiding sed'iting scripts and miscellaneous files. Some GNUish makefiles are about 10 times as long as BSDish makefiles because they handling things more generally. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604302021.GAA21324>