Date: Wed, 15 Aug 2018 11:18:55 -0600 From: Brad Davis <brd@FreeBSD.org> To: Ravi Pokala <rpokala@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337857 - in head: bin/csh bin/sh etc Message-ID: <1534353535.920234.1475238264.523AA6C6@webmail.messagingengine.com> In-Reply-To: <3E8B8322-9A8A-4EC0-95C6-7180659E9723@panasas.com> References: <201808151622.w7FGMCN7024455@repo.freebsd.org> <3E8B8322-9A8A-4EC0-95C6-7180659E9723@panasas.com>
index | next in thread | previous in thread | raw e-mail
On Wed, Aug 15, 2018, at 11:17 AM, Ravi Pokala wrote: > Brad, > > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Brad Davis > <brd@FreeBSD.org> > Date: 2018-08-15, Wednesday at 09:22 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src- > head@freebsd.org> > Subject: svn commit: r337857 - in head: bin/csh bin/sh etc > > > Author: brd > > Date: Wed Aug 15 16:22:12 2018 > > New Revision: 337857 > > URL: https://svnweb.freebsd.org/changeset/base/337857 > > > > Log: > > Fix build after r337849 > > > > This moves the symlink creation to after where the files are installed. > > > > This also inverts the shell change so that it only happens if MK_TCSH is on. > ... > > Modified: head/etc/master.passwd > > ============================================================================== > > --- head/etc/master.passwd Wed Aug 15 16:16:59 2018 (r337856) > > +++ head/etc/master.passwd Wed Aug 15 16:22:12 2018 (r337857) > > @@ -1,6 +1,6 @@ > > # $FreeBSD$ > > # > > -root::0:0::0:0:Charlie &:/root:/bin/csh > > +root::0:0::0:0:Charlie &:/root:/bin/sh > > toor:*:0:0::0:0:Bourne-again Superuser:/root: > > daemon:*:1:1::0:0:Owner of many system processes:/root:/usr/sbin/nologin > > operator:*:2:5::0:0:System &:/:/usr/sbin/nologin > > Woah! Changing the root shell wasn't mentioned in the change > description, has nothing to do with fixing r337849, and is a *HUGE* POLA > violation. At the very least, a change of this magnitude needs public > discussion, and even if the community agreed, it would also require an > UPDATING message and relnote. > > Please revert this change to master.passwd immediately. Hi Ravi, Please, look closer. It doesn't change what is actually installed in either case, it just inverts the logic. Regards, Brad Davishome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1534353535.920234.1475238264.523AA6C6>