Date: Wed, 22 Aug 2018 09:25:42 +0200 From: Tobias Kortkamp <tobik@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r477722 - head/print/magicfilter Message-ID: <1534922742.673192.1482199456.404603FB@webmail.messagingengine.com> In-Reply-To: <20180822070034.nmyni3ogxuqaok7j@atuin.in.mat.cc> References: <201808211617.w7LGHbVa018387@repo.freebsd.org> <20180822070034.nmyni3ogxuqaok7j@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 22, 2018, at 09:00, Mathieu Arnold wrote: > On Tue, Aug 21, 2018 at 04:17:37PM +0000, Tobias Kortkamp wrote: > > Author: tobik > > Date: Tue Aug 21 16:17:36 2018 > > New Revision: 477722 > > URL: https://svnweb.freebsd.org/changeset/ports/477722 > > > > Log: > > print/magicfilter: Prevent ccache from being accidentally added as a run dependency > > > > PR: 218268 > > Submitted by: Andreas Hollmann <andreas.hollmann@gmail.com> > > > > Modified: > > head/print/magicfilter/Makefile > > > > Modified: head/print/magicfilter/Makefile > > ============================================================================== > > --- head/print/magicfilter/Makefile Tue Aug 21 15:56:20 2018 (r477721) > > +++ head/print/magicfilter/Makefile Tue Aug 21 16:17:36 2018 (r477722) > > @@ -3,7 +3,7 @@ > > > > PORTNAME= magicfilter > > PORTVERSION= 2.3.h > > -PORTREVISION= 8 > > +PORTREVISION= 9 > > CATEGORIES= print > > MASTER_SITES= http://www.pell.portland.or.us/~orc/Code/magicfilter/ > > > > @@ -22,7 +22,7 @@ CONFIGURE_ENV+= LOCALBASE=${LOCALBASE} > > > > .if exists(${LOCALBASE}/lib/libmagic.so) > > BUILD_DEPENDS+= ${LOCALBASE}/lib/libmagic.so:sysutils/file > > -RUN_DEPENDS+= ${BUILD_DEPENDS} > > +RUN_DEPENDS:= ${BUILD_DEPENDS} > > .endif > > I do not know what happens before this, but it would probably be more > right to have: > > RUN_DEPENDS+= ${LOCALBASE}/lib/libmagic.so:sysutils/file The current form was suggested by bredwery@ in the PR, but I may have misinterpreted his comment a little. I've changed it back to how the original submission was.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1534922742.673192.1482199456.404603FB>