Date: Sat, 1 Feb 2025 12:58:57 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f1bf1c22a0c - main - umb: Introduce the USB umb(4) network driver Message-ID: <4n0s7403-2177-581r-s0qn-q5psor42no8s@serrofq.bet> In-Reply-To: <Z52yXTDUVCQMJveZ@cell.glebi.us> References: <202501202347.50KNleC1038560@gitrepo.freebsd.org> <859rn769-r59r-71q6-qoqs-90ps5qps488p@SerrOFQ.bet> <CAJ-Vmok=H6vVYrMkY9%2B10VfNBB3fJH5F6e8=bmCdJNSaG3RAaQ@mail.gmail.com> <Z52yXTDUVCQMJveZ@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 Jan 2025, Gleb Smirnoff wrote:
> On Fri, Jan 31, 2025 at 08:16:53PM -0800, Adrian Chadd wrote:
> A> > > commit 0f1bf1c22a0c97e84a4db19197a75952487aa20b
> A> > > Author: Adrian Chadd <adrian@FreeBSD.org>
> A> > > AuthorDate: 2025-01-20 23:46:15 +0000
> A> > > Commit: Adrian Chadd <adrian@FreeBSD.org>
> A> > > CommitDate: 2025-01-20 23:46:15 +0000
> A> > >
> A> > > umb: Introduce the USB umb(4) network driver
> A> >
> A> > Still breaks at least:
> A> > amd64 MINIMAL kernel failed, check _.amd64.MINIMAL for details
> A> > amd64 MINIMALUP kernel failed, check _.amd64.MINIMALUP for details
> A>
> A> It wasn't broken when it landed, I did a universe pass.
>
> This is not related to Adrian's changes, but to 1111a44301da39d7b7459c784230e1405e8980f8.
>
> I have the patch in my queue, waiting for universe.
Sorry. My fault.
umb only has an unused function in the default compile settings due to a
missing #ifdef DEV_NETMAP.
24 1 warning generated.
25 /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/usb/net/if_umb.c:848:1: warning: unused function 'umb_input' [-Wunused-function]
26 848 | umb_input(if_t ifp, struct mbuf *m)
27 | ^~~~~~~~~
--
Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4n0s7403-2177-581r-s0qn-q5psor42no8s>