Date: Fri, 1 Jun 2001 19:06:34 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jesper Skriver <jesper@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_accf.c uipc_mbuf.c uipc_socket2.c src/sys/netinet ip_input.c src/sys/netinet6 in6_proto.c src/sys/sys param.h Message-ID: <Pine.BSF.4.21.0106011853510.32386-100000@besplex.bde.org> In-Reply-To: <200105312158.f4VLwB659138@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 31 May 2001, Jesper Skriver wrote:
> jesper 2001/05/31 14:58:11 PDT
>
> Modified files:
> sys/kern uipc_accf.c uipc_mbuf.c uipc_socket2.c
> Log:
> Move the definition of NMBCLUSTERS from src/sys/kern/uipc_mbuf.c
> to <sys/param.h>, so it's available to src/sys/netinet/ip_input.c,
> and remove the now unneeded includes of "opt_param.h".
These includes are bogus (but needed). From /sys/conf/options:
---
# Options used only in param.c.
^^^^
^^^^
^^^^
^^^^
HZ opt_param.h
MAXFILES opt_param.h
MAXUSERS opt_param.h
NBUF opt_param.h
NMBCLUSTERS opt_param.h
NSFBUFS opt_param.h
---
> Modified files:
> sys/sys param.h
> Log:
> Move the definition of NMBCLUSTERS from src/sys/kern/uipc_mbuf.c
> to <sys/param.h>, so it's available to src/sys/netinet/ip_input.c
Options files shall not be included in any header. Including one in
<sys/param.h> is especially broken. It breaks, at least, all modules.
Here is the start of the breakage (in the first module):
---
===> 3dfx
Warning: Object directory not changed from original /c/sysc/modules/3dfx
@ -> /c/sysc
machine -> /c/sysc/i386/include
echo "#define TDFX_LINUX" > opt_tdfx.h
perl @/kern/makeobjops.pl -h @/kern/bus_if.m
perl @/kern/makeobjops.pl -h @/dev/pci/pci_if.m
perl @/kern/makeobjops.pl -h @/kern/device_if.m
cc -O -pipe -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/dev -I@/../include -I/usr/include -mno-align-long-strings -mpreferred-stack-boundary=2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -c /c/sysc/modules/3dfx/../../dev/tdfx/tdfx_pci.c
In file included from /c/sysc/modules/3dfx/../../dev/tdfx/tdfx_pci.c:41:
@/sys/param.h:236: opt_param.h: No such file or directory
*** Error code 1
Stop in /c/sysc/modules/3dfx.
*** Error code 1
Stop in /c/sysc/modules.
---
> MFC after: 1 week
Termination after: a few hours.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0106011853510.32386-100000>