Date: Mon, 2 Jul 2012 09:42:24 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "svn-src-head@FreeBSD.org" <svn-src-head@FreeBSD.org>, Dag-Erling Sm?rgrav <des@des.no>, Baptiste Daroussin <bapt@FreeBSD.org>, "src-committers@FreeBSD.org" <src-committers@FreeBSD.org>, "svn-src-all@FreeBSD.org" <svn-src-all@FreeBSD.org> Subject: Re: svn commit: r237997 - in head: tools/build/mk tools/build/options usr.sbin Message-ID: <5D283E88-BB45-4188-9EC4-7301A6232D01@gmail.com> In-Reply-To: <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net> References: <201207021528.q62FSoot078093@svn.freebsd.org> <2B78C1CB-FC64-4C78-94D1-B01F02C02D2D@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 2, 2012, at 9:32 AM, Marcel Moolenaar <marcel@xcllnt.net> wrote: >=20 > On Jul 2, 2012, at 8:28 AM, Baptiste Daroussin wrote: >=20 >> Author: bapt >> Date: Mon Jul 2 15:28:50 2012 >> New Revision: 237997 >> URL: http://svn.freebsd.org/changeset/base/237997 >>=20 >> Log: >> New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of usr.sbin/pk= g >> Do not condition usr.sbin/pkg building on WITHOUT_PKGTOOLS anymore, so th= at users can >> remove the old pkg_* tools without removing the pkgng boostrap >=20 > Oh, and: >=20 >> Added: head/tools/build/options/WITHOUT_PKGBOOSTRAP >=20 > You have a typo in the options filename as well. >=20 > With all those mistakes and typos, I cannot escape the notion that this is= a > rushed commit or at least that it didn't get the attention it should have > gotten. Worse, it wasn't caught by your mentor. >=20 > des: please give reviews more attention > bapt: it sometimes helps to review your own patches as if they weren't you= rs. > you won't catch as much as a real 3rd party would, because they are > still your patches and you're bound to overlook stuff, but at least > you may catch some of the boneheaded stuff. The other thing is that src.conf(5) wasn't regenerated after the commit (the= knob and the src.conf commit should be done separately to as src.conf gener= ation is driven by $Revision$ in the knob file. Thanks, -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5D283E88-BB45-4188-9EC4-7301A6232D01>