Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 7 Nov 2015 19:33:57 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r290507 - head/sys/dev/isp
Message-ID:  <201511071933.tA7JXvU8056436@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: mav
Date: Sat Nov  7 19:33:57 2015
New Revision: 290507
URL: https://svnweb.freebsd.org/changeset/base/290507

Log:
  Rework r290504.

Modified:
  head/sys/dev/isp/isp.c
  head/sys/dev/isp/isp_freebsd.h

Modified: head/sys/dev/isp/isp.c
==============================================================================
--- head/sys/dev/isp/isp.c	Sat Nov  7 19:03:47 2015	(r290506)
+++ head/sys/dev/isp/isp.c	Sat Nov  7 19:33:57 2015	(r290507)
@@ -2774,7 +2774,7 @@ isp_fclink_test(ispsoftc_t *isp, int cha
 	 */
 	lwfs = FW_CONFIG_WAIT;
 	GET_NANOTIME(&hra);
-	do {
+	while (1) {
 		isp_fw_state(isp, chan);
 		if (lwfs != fcp->isp_fwstate) {
 			isp_prt(isp, ISP_LOGCONFIG|ISP_LOG_SANCFG, "Chan %d Firmware State <%s->%s>", chan, isp_fc_fw_statename((int)lwfs), isp_fc_fw_statename((int)fcp->isp_fwstate));
@@ -2783,9 +2783,11 @@ isp_fclink_test(ispsoftc_t *isp, int cha
 		if (fcp->isp_fwstate == FW_READY) {
 			break;
 		}
-		ISP_SLEEP(isp, 1000);
 		GET_NANOTIME(&hrb);
-	} while (NANOTIME_SUB(&hrb, &hra) / 1000 < usdelay);
+		if ((NANOTIME_SUB(&hrb, &hra) / 1000 + 1000 >= usdelay))
+			break;
+		ISP_SLEEP(isp, 1000);
+	}
 
 	/*
 	 * If we haven't gone to 'ready' state, return.

Modified: head/sys/dev/isp/isp_freebsd.h
==============================================================================
--- head/sys/dev/isp/isp_freebsd.h	Sat Nov  7 19:03:47 2015	(r290506)
+++ head/sys/dev/isp/isp_freebsd.h	Sat Nov  7 19:33:57 2015	(r290507)
@@ -401,10 +401,10 @@ struct isposinfo {
 #define	ISP_SNPRINTF		snprintf
 #define	ISP_DELAY(x)		DELAY(x)
 #if __FreeBSD_version < 1000029
-#define	ISP_SLEEP(isp, x)	msleep(&(isp)->isp_osinfo.lock, \
+#define	ISP_SLEEP(isp, x)	msleep(&(isp)->isp_osinfo.is_exiting, \
     &(isp)->isp_osinfo.lock, 0, "isp_sleep", ((x) + tick - 1) / tick)
 #else
-#define	ISP_SLEEP(isp, x)	msleep_sbt(&(isp)->isp_osinfo.lock, \
+#define	ISP_SLEEP(isp, x)	msleep_sbt(&(isp)->isp_osinfo.is_exiting, \
     &(isp)->isp_osinfo.lock, 0, "isp_sleep", (x) * SBT_1US, 0, 0)
 #endif

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201511071933.tA7JXvU8056436>