Date: Mon, 10 Mar 2025 14:15:52 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Ravi Pokala <rpokala@freebsd.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK Message-ID: <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org> In-Reply-To: <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com> References: <202503101735.52AHZiu6027210@gitrepo.freebsd.org> <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/10/25 13:41, Ravi Pokala wrote: > Hi John, > >> This reverts commit 234683726708cf5212d672d676d30056d4133859. > > The commit message for that change says that this allocation might be done while holding a lock, and so M_WAITOK is not valid. So then why is this change okay? > > Thanks, Because the earlier commit to sdhci in this same push fixed it to create devices in a sleepable context. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ffc904b-7a14-412e-bf08-4703b00e3ffb>