Date: Thu, 19 Nov 2015 13:08:32 -0800 From: Sean Bruno <sbruno@freebsd.org> To: John Baldwin <jhb@freebsd.org>, freebsd-current@freebsd.org Cc: 'Warner Losh' <imp@bsdimp.com> Subject: Re: sys/modules "make clean" seems broken again Message-ID: <564E3A50.40600@freebsd.org> In-Reply-To: <3514235.7QMnNNElsE@ralph.baldwin.cx> References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 11/19/15 10:12, John Baldwin wrote: > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: >> I thought I fixed this a year or two ago, but now a "make clean" >> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h >> in the directory. >> >> Should I just add these to the clean targets? > > Blame Warner as his MFILES changes broke this. In particular, see > r287263 which turned off cleaning these up. I'm not sure what that > broke that caused it to be disabled. > > Your change is a gross hack though. > Definitely. Just committing that would be pretty bad. There's similar code above it that I used as a template for this change. I'm not sure that its any less gross ... :-( sean -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJWTjpQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5k5AsH/2z3H/jFttevRnWKKP9C4DUM qkZKz3KjvQHDmlGXjPsfsAJQO7ngsoleGnFCFipRzk2ICmhfJQFcKYeSyUJVvRiO 91MkcQHEzmy4bOdLNbAKj5b9R/WtFwOdY3HwPyiI1tnxRTovnT2gJ5Qg0u6oNFdw RAFMrn9hMMYxcHRGjJyfOdXP0fYpb752oAlJR1cL3lpsh6MqZfqhDCZShimnveht R71BTUqQu3X4YdeXt4CRWFqwGchQD0J0T/wFp0JqA5oM2uK1JxenHqz/5mNzuQol X8xjrhN/Bh5sLK+QFsdBcmlbQ6aEsy7Dq8Abm7tWz46TCO1qcp1SgU+7Ny1+9eY= =f5LD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564E3A50.40600>