Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Dec 2023 22:21:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 275741] sys/modules: Fix processing of WITHOUT_MODULES
Message-ID:  <bug-275741-227-PzDfokcyEw@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-275741-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-275741-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275741

Joshua Kinard <freebsd@kumba.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247024|0                           |1
        is obsolete|                            |

--- Comment #2 from Joshua Kinard <freebsd@kumba.dev> ---
Created attachment 247035
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247035&action=
=3Dedit
Fix processing of WITHOUT_MODULES v2

This version of the patch fixes an accidental bug in the kmod.without.mk for
loop where I was trying to be too clever and compare `basename CURDIR` agai=
nst
`dirname kmod` to try and limit accidental matches from being removed from
SUBDIR.  A.k.a., being overly-cautious and while that check works for a sin=
gle
subdirectory level (foo/bar), it fails if the kmod name in WITHOUT_MODULES =
has
several subdirectory levels (foo/bar/baz).  After adding better debugging a=
nd
looking through the build log, the conditional simply isn't needed, so it is
removed in this version.

Also updated the date in the make.conf.5 man page.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-275741-227-PzDfokcyEw>