Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 7 Apr 2016 07:35:02 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r297651 - stable/10/sys/ofed/drivers/net/mlx4
Message-ID:  <201604070735.u377Z2Eb079163@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: hselasky
Date: Thu Apr  7 07:35:02 2016
New Revision: 297651
URL: https://svnweb.freebsd.org/changeset/base/297651

Log:
  MFC r296910:
  Use hardware computed Toeplitz hash for incoming flowids
  
  Use the Toeplitz hash value as source for the flowid. This makes the
  hash value more suitable for so-called hash bucket algorithms which
  are used in the FreeBSD's TCP/IP stack when RSS is enabled.
  
  Sponsored by:	Mellanox Technologies

Modified:
  stable/10/sys/ofed/drivers/net/mlx4/en_rx.c
  stable/10/sys/ofed/drivers/net/mlx4/en_tx.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/ofed/drivers/net/mlx4/en_rx.c
==============================================================================
--- stable/10/sys/ofed/drivers/net/mlx4/en_rx.c	Thu Apr  7 07:33:40 2016	(r297650)
+++ stable/10/sys/ofed/drivers/net/mlx4/en_rx.c	Thu Apr  7 07:35:02 2016	(r297651)
@@ -616,7 +616,8 @@ int mlx4_en_process_rx_cq(struct net_dev
 			goto next;
 		}
 
-		mb->m_pkthdr.flowid = cq->ring;
+		/* forward Toeplitz compatible hash value */
+		mb->m_pkthdr.flowid = be32_to_cpu(cqe->immed_rss_invalid);
 		M_HASHTYPE_SET(mb, M_HASHTYPE_OPAQUE);
 		mb->m_pkthdr.rcvif = dev;
 		if (be32_to_cpu(cqe->vlan_my_qpn) &

Modified: stable/10/sys/ofed/drivers/net/mlx4/en_tx.c
==============================================================================
--- stable/10/sys/ofed/drivers/net/mlx4/en_tx.c	Thu Apr  7 07:33:40 2016	(r297650)
+++ stable/10/sys/ofed/drivers/net/mlx4/en_tx.c	Thu Apr  7 07:35:02 2016	(r297651)
@@ -1057,7 +1057,7 @@ mlx4_en_transmit(struct ifnet *dev, stru
 
 	/* Compute which queue to use */
 	if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) {
-		i = m->m_pkthdr.flowid % priv->tx_ring_num;
+		i = (m->m_pkthdr.flowid % 128) % priv->tx_ring_num;
 	}
 	else {
 		i = mlx4_en_select_queue(dev, m);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604070735.u377Z2Eb079163>