Date: Wed, 23 Nov 2005 00:02:55 +0100 From: Pav Lucistnik <pav@FreeBSD.org> To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/89300: [MAINTAINER] multimedia/bsdav: remove BROKEN Message-ID: <1132700575.47320.16.camel@localhost> In-Reply-To: <20051123005108.14ffff2e@it.buh.tecnik93.com> References: <200511222220.jAMMK1bB012364@freefall.freebsd.org> <20051123003447.7046be7d@it.buh.tecnik93.com> <1132699378.47320.12.camel@localhost> <20051123005108.14ffff2e@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-DwIvBOtbcmuFCIXSABGR
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Ion-Mihai Tetcu p=ED=B9e v st 23. 11. 2005 v 00:51 +0200:
> On Tue, 22 Nov 2005 23:42:58 +0100
> Pav Lucistnik <pav@FreeBSD.org> wrote:
>=20
> > Ion-Mihai Tetcu p=ED=B9e v st 23. 11. 2005 v 00:34 +0200:
> > > On Tue, 22 Nov 2005 22:20:01 GMT
> > > Pav Lucistnik <pav@FreeBSD.org> wrote:
> > >=20
> > > > Synopsis: [MAINTAINER] multimedia/bsdav: remove BROKEN
> > > >=20
> > > > State-Changed-From-To: open->closed
> > > > State-Changed-By: pav
> > > > State-Changed-When: Tue Nov 22 22:19:30 GMT 2005
> > > > State-Changed-Why:=20
> > > > Committed with fixes. Next time, what about running portlint(1)?
> > >=20
> > > What was wrong ? ``^^'' =3D my comments
> > >=20
> > > root@it> /usr/ports/multimedia/bsdav.my [0:32:16] 0
> > > # portlint -A
> >=20
> > You should be running either `portlint -AN' for new ports or `portlint
> > -C' for updates ...
>=20
> Still, what was the problem ? I wanna learn, not make you loose time, you
> know :)
>=20
> root@it> /usr/ports/multimedia/bsdav.my [0:46:11] 0
> # portlint -C
> WARN: Makefile [26]: possible direct use of command "install" found. use =
${INSTALL_foobaa} instead.
> ^^ false
> WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_tables.c [8]: =
includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import.
> WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_video_hw.c [8]=
: includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import.
> ^^ are this two a problem ?
> WARN: no CVS directories. Use -N to check a new port.
> ^^ 'casue I've copied the port in bsdav.my; in the PR is OK (bsdav)
> 0 fatal errors and 4 warnings found.
I got different output. You're using latest and greatest portlint 2.8.0?
I got the IGNORE capitalization message.
Anyway, my changes:
First, you don't raise PORTREVISION on change that don't affect package.
Second, your IGNORE string does not make any sense when used. I fixed
that.
Third, you used OPTIONS incorrectly. I fixed that. For details, see
chapter in PH.
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
It whines, glows and fades...
--=-DwIvBOtbcmuFCIXSABGR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
=?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQBDg6OfntdYP8FOsoIRAoWRAKCXg2KGxKJq0WGhMOC/mS4BiCch7ACfbxX9
z4conUoGjk4D0YuzOPS2Rp4=
=bLmF
-----END PGP SIGNATURE-----
--=-DwIvBOtbcmuFCIXSABGR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1132700575.47320.16.camel>