Date: Wed, 20 Sep 2006 22:56:18 +0400 From: Ruslan Ermilov <ru@freebsd.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c Message-ID: <20060920185618.GA28844@rambler-co.ru> In-Reply-To: <bb4a86c70609200944x32c0c3cfu60190684f654a642@mail.gmail.com> References: <bb4a86c70609191415m59a9ef89x91f25e6912339390@mail.gmail.com> <20060919215605.GB44298@rambler-co.ru> <20060919221404.GT94944@alchemy.franken.de> <20060920055715.GA81843@rambler-co.ru> <20060920121017.GU94944@alchemy.franken.de> <20060920122830.GB982@rambler-co.ru> <20060920162105.GC9976@rambler-co.ru> <bb4a86c70609200928i4196c7ceu1a958d815728a5d7@mail.gmail.com> <20060920163710.GA28144@rambler-co.ru> <bb4a86c70609200944x32c0c3cfu60190684f654a642@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Sep 20, 2006 at 09:44:49AM -0700, Maksim Yevmenkin wrote:
> On 9/20/06, Ruslan Ermilov <ru@freebsd.org> wrote:
> >On Wed, Sep 20, 2006 at 09:28:46AM -0700, Maksim Yevmenkin wrote:
> >> On 9/20/06, Ruslan Ermilov <ru@freebsd.org> wrote:
> >> >Here's another demo that indicates that sparc64 doesn't work
> >> >properly. In this case it's a CONS_SETKBD ioctl which is used
> >> >by kbdcontrol(8). I "kldload vkbd" and make sure two vkbd
> >> >instances exist, /dev/vkbdctl0 and /dev/vkbdctl1.
> >>
> >> [...]
> >>
> >> actually, i just tracked this down as part of my work on pr
> >> sparc64/96798. there are few problems mentioned in this pr. kbdcontrol
> >> -k not working is just one of them.
> >>
> >> basically, kb_index is wrong, and, in my case, is always 0. which
> >> defaults to first keyboard (i.e. subkbd(4)). that is why i can not use
> >> kbdcontrol -k to switch between sunkbd(4) and, say, ukbd(4).
> >>
> >Yes, this is the endianness bug we were talking about.
> >Hold on, the fix is almost ready. :-)
>=20
> sure, btw i think CONS_SETKBD is easy. nothing seems to calling it
> from the kernel, so we could (intptr_t *) cast it and it should just
> work. i really want to change it to
>=20
> #define CONS_SETKBD _IOW('c', 110, int)
>=20
Yes, it would break both binary and source API compatibility. No
we cannot do it.
> because i officially hate _IO() now :) but i'm not sure if this breaks
> binary compatibility.
>=20
> me makes a mental note to never ever use _IO() anymore.
>=20
I fully share your sentiments. :-)
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--LQksG6bCIzRHxTLp
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFFEY7SqRfpzJluFF4RAv9hAJ49YHAbEfvXrCazeUw8G+g3iwjVcQCdGWWp
ZYivvoa5J+9RK9U4Ag2Vib8=
=TG/V
-----END PGP SIGNATURE-----
--LQksG6bCIzRHxTLp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060920185618.GA28844>