Date: Tue, 21 Oct 2014 19:49:33 -0600 From: Warner Losh <imp@bsdimp.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r273417 - head Message-ID: <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> In-Reply-To: <86d29k28wh.fsf@nine.des.no> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Oct 21, 2014, at 7:25 PM, Dag-Erling Smørgrav <des@des.no> wrote: > Warner Losh <imp@FreeBSD.org> writes: >> Author: imp >> Date: Tue Oct 21 20:29:42 2014 >> New Revision: 273417 >> URL: https://svnweb.freebsd.org/changeset/base/273417 >> >> Log: >> You aren't allowed to test WITH_xxx or WITHOUT_xxx here, so remove it. >> Even if you were allowed to test for it, the test makes no sense as it >> always results in adding -DWITH_ATF unless WITH_ATF was already >> defined. But if MK_ATF != no, then we know it was defined. This, in >> turn, caused tools/build/options/makemake always think WITH_ATF is the >> default, which removed control of that from sys.conf.mk. >> >> To get the intent of the deleted comment, another mechanism is >> required, assuming that the intent of that comment is desirable. > > This broke the paralell build. It prevents building lib/atf entirely in > stage 4.3, so the programs in libexec/atf have nothing to link against > unless lib/atf just happens to get built before libexec/atf. That > almost never happens: lib and libexec are built in paralell, and lib/atf > is one of the last items in lib whereas libexec/atf is one of the first > items in libexec. > > (on a side note, libatf doesn't need to be in _prebuild_libs, since no > other library depend on it) Yea, it was AFU. I’ll fix this. I think we need to have a MK_TESTS_SUPPORT that builds the libatf stuff when yes, and omits it when no, since we don’t want the tests building when we’re building the 4.3 stage. Warner > DES > -- > Dag-Erling Smørgrav - des@des.no [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJURw0uAAoJEGwc0Sh9sBEAkrgP/R5+U6/6T8k04jHhvPK8FKxy kwJ2yJcGpO3jCo0ky9xDLmtdA5bu0mSkSnG9peCE4pYhRZsWpBptXHOyf8Wd45m1 qnHLci3uPAyW7qy2RqZuQN/XNMr274wtbS3J1O2HURGi17pUT2PNJaJagP0ppZ2Y vP/923VRA9TuyuPifYXEO+QdmuEExrJy2ATfzqI40nulFXahGsm0BEY1+RqhBP6o tUu1S8ZrsXKKZBsSclFHync+WIDntPHSMMYQDmhiTNvqoLWFhBMKcNuEGSiOd1J7 6DgdBuGn+BmcjXovpGysZYMqaahz8+OFbEDEfPh4ADv1sL/JGEauDV5/kY12kOLX Ds9arPAbdAyi6xbLSZf4heTQ7Cc4oB3R08DqD0ATWb5bF7/gDXxR4MgVsNUq4hiH gnYmoBwsc0OKr5r83FjWSabUnPqvSLlNDqdhXY8YDMmbTVsep9VKQ8zHXoAcL+37 fk/QR/UU2llEy9hhDj1/0LBLMxz449w8ybQmIqRLz7Ghe3HYC2VSVIl9Z4KecGxG CF2/uTF9yU4TzToB+GBe8Tlc6qdziiERge6k8rNp9KArXz1fb0Cjq36HakGbUFNu 5KqzZ3pbWfNwcIRmMmhp5cfFWZx183VNxNsWY6FeCz8yItOfdOjek0gmkY8yBSmY BTKVIY7Hls7i1AcERrow =Rt/o -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22788EC4-3BDF-40F3-ACAC-FA686ED21154>